Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Geant4 recipe to allow an external directory for data sets, clean-up: #2453

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Modify Geant4 recipe to allow an external directory for data sets, clean-up: #2453

merged 2 commits into from
Sep 16, 2020

Conversation

ihrivnac
Copy link
Contributor

  • Added GEANT4_DATADIR variable which allows to override the default installation
    path for data sets (CMAKE_INSTALL_DATAROOTDIR)
  • Replaced auto discovery of data installation paths (not working when data for more Geant4
    versions are installed in the same directory) with use of geant4-config script
  • Removed G4INSTALL, G4INSTALL_DATA, G4SYSTEM env variables (not needed)
  • Removed appending ROOT_INCLUDE_PATH with Geant4 includes (not needed)

@ihrivnac
Modify Geant4 recipe to make possible to define an external directory…
7fc334c 
… for data sets, plus clean-up:

- Added GEANT4_DATADIR variable which allows to override the default installation
  path for data sets (CMAKE_INSTALL_DATAROOTDIR)
- Replaced auto discovery of data installation paths (not working when data for more Geant4
  versions are installed in the same directory) with use of geant4-config script
- Removed G4INSTALL, G4INSTALL_DATA, G4SYSTEM env variables (not needed)
- Removed appending ROOT_INCLUDE_PATH with Geant4 includes (not needed)
@ihrivnac
Copy link
Contributor Author

Motivation for this update:
Using a dedicated data sets directory can save compilation time and disk space, as some data sets are shared by several Geant4 versions and data sets need not to be downloaded again with each rebuilding of Geant4, what is the case when the default installation path is used.

@ihrivnac ihrivnac requested a review from sawenzel August 28, 2020 07:50
@ihrivnac
Copy link
Contributor Author

@MichaelLettrich , the build/alidist/O2Suite/o2/macOS build is in Expected state since 1 day; is it normal or is the builder stuck? Thank you.

@ihrivnac
Copy link
Contributor Author

ihrivnac commented Sep 1, 2020

The two failures are nor relevant to this PR:
The one on build/alidist/O2Suite/o2/macOS is caused by no space left:
\TOFCalibration.dir/G__O2TOFCalibration.cxx.o
fatal error: error in backend: IO failure on output stream: No space left on device
And the one in build/O2/alidist-dataflow is non related compilation error.

@sawenzel , should I update the branch to trigger new build, or is it ok to approve? Thank you.

@ihrivnac ihrivnac requested a review from ktf September 3, 2020 14:02
@ktf
Copy link
Member

ktf commented Sep 3, 2020

@MichaelLettrich looks like macOS is still having troubles.

@ihrivnac
Copy link
Contributor Author

All checks passed ok. Ping @sawenzel , @ktf .

@ktf ktf merged commit ca28635 into alisw:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawenzel sawenzel sawenzel approved these changes

@ktf ktf Awaiting requested review from ktf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ihrivnac @ktf @sawenzel