Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ROOT_INCLUDE_PATH #1547

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Add missing ROOT_INCLUDE_PATH #1547

merged 1 commit into from
Mar 18, 2019

Conversation

dberzano
Copy link
Contributor

@dberzano dberzano commented Mar 18, 2019 •
edited
Loading

See AliceO2Group/AliceO2#1800. Affected:

  • Vc
  • ms_gsl
  • GEANT4
  • GEANT4_VMC
  • AliTPCCommon

@dberzano dberzano requested a review from a team as a code owner March 18, 2019 13:13
@dberzano dberzano force-pushed the add_missing_root_include branch 2 times, most recently from 0cdb5c5 to 8fc858d Compare March 18, 2019 15:42
Add missing ROOT_INCLUDE_PATH
e35a383 
See AliceO2Group/AliceO2#1800. Affected:

* Vc
* ms_gsl
* GEANT4
* GEANT4_VMC
* AliTPCCommon
@dberzano dberzano force-pushed the add_missing_root_include branch from 8fc858d to e35a383 Compare March 18, 2019 15:48
@dberzano dberzano mentioned this pull request Mar 18, 2019
Merged
@ktf
Copy link
Member

ktf commented Mar 18, 2019

I guess the multiple include paths will hit us at some point, but for now, good enough since it fixes an actual problem.

@ktf ktf merged commit bf4f39e into alisw:master Mar 18, 2019
@dberzano dberzano deleted the add_missing_root_include branch March 19, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktf ktf ktf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dberzano @ktf