-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Run2/Run3 GCC and GEANT4s #1415
Conversation
Hi @dberzano |
geant4.sh
Outdated
@@ -1,7 +1,7 @@ | |||
package: GEANT4 | |||
version: "%(tag_basename)s" | |||
tag: v4.10.01.p03-alice1 | |||
source: https://github.com/alisw/geant4 | |||
tag: v10.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is quite a big version change for Run2. Is this supported by the DPG? Will they have to rerun all the Geant4 validation productions? Do we have a validation procedure when bumping Geant4?
@alisw/dpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC it was discussed a couple of weeks ago at the CB, @pzhristov can maybe confirm that we've even taken a decision to this respect? I let him comment on this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since Geant4 is not in production anyway, we better align all the versions. This will help to make also the comparisons in a meaningful way avoiding differences from the compiler.
This is fine for me, but can we rationalise a bit the number of defaults we have? Do we really need so many? |
@ktf I am doing that as a matter of fact. Hold on. |
@pzhristov what is the GEANT4 version you suggest we use? |
Hi @dberzano, I think we should test the build with the last tagged version that Ivana proposed, 10.4.2. https://github.com/Geant4/geant4/releases/tag/v10.4.2 Cheers, |
57dd385
to
2353f41
Compare
OK I have bumped GEANT4 (but I am not sure whether we should bump the VMC as well). |
@dberzano, We need geant4_vmc version v3-6-p1, the current one does not compile. There is also a problem with ninja generator in AliRoot, I see CMake Error at CMakeLists.txt:318 (enable_language):
due to lack of required features. Kitware has implemented the required
with the required features. One may build ninja from that branch to get -- Configuring incomplete, errors occurred! |
@pzhristov I do know about the ninja stuff. The ninja recipe takes exactly the steps you illustrate. However, I did not deliberately enable it, there must be a problem with my recipe that I am going to fix. Thanks for the heads-up on g4vmc! |
@dberzano The patch excluding ninja solves the compilation issues, now everything is fine on Ubuntu 16.04. The gun test is OK with the patched master of Root6. |
2b2535f
to
7dc26db
Compare
7dc26db
to
86b739d
Compare
* Align as much as possible Run 2 and Run 3 defaults: use the same ROOT 6 version and build options * Make ROOT 5 builds the exception, not the rule: they are now deprecated, so their defaults are now overriding what they need (not the other way around) * Remove Ninja defaults and add automatic Ninja support for O2 and AliPhysics in development mode: if `ninja` is found it will be used * Remove some other unused defaults * Align `release` and `prod-latest`, the latter being deprecated in favour of the first. Since most of the automatic checking machinery still uses `prod-latest` we are keeping it for now, but it will be removed in a future PR * Bump GEANT4 to v10.4.2 and GEANT4_VMC to v3-6-p1 (upstream versions) * Use the same GCC everywhere * Merge the two JAliEn defaults into one
5ca5af3
to
8f5f348
Compare
As requested by @pzhristov