-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory limit issue on iOS #64
Comments
I concur, thanks for a great lib! I'm experiencing the same issue. And after opening the share extension three or four times it crashes. Please let us know if we can assist in any way. |
I fixed this in weird way: So solution is to crash extension :) |
@exentrich thanks for the idé 👍 I will implement this on my end until there is a patch for the memory issue |
@exentrich @karlAlnebratt hysterical. For future comers, I wound up modifying the close method to both crash and add an animation. Don't forget to add RCT_EXPORT_METHOD(close) {
dispatch_async(dispatch_get_main_queue(), ^{
[UIView animateWithDuration:0.3
animations:^(void){
CGRect rect = rootView.frame;
rect.origin.y = 2 * rect.size.height;
rootView.frame = rect;
}
completion:^(BOOL finished){
[extensionContext completeRequestReturningItems:nil
completionHandler:nil];
@throw NSInternalInconsistencyException;
}];
});
} |
Why isn't #64 (comment) in the repo? is there any proper way to close it without crashing it? |
hey @exentrich, its been a while. do u recall what u meant with this? When I called a non-existing function or a throw an Error the extension crashes, not silently. How could I call a failing js function to release memory and not make the extension crash? Thanks in advance |
Thank you very much for this great library!
Right now i have only one issue. When i open and close extension, memory consumption only increase (double every time). After some reopens it crashes, because strict memory limits for extensions on iOS.
It's looks like when extension is closed it not freeing memory.
Maybe you have some ideas, how to force free memory?
The text was updated successfully, but these errors were encountered: