Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtAV] Image sequence caching #36

Merged
merged 26 commits into from
Jul 12, 2023
Merged

[qtAV] Image sequence caching #36

merged 26 commits into from
Jul 12, 2023

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Apr 18, 2023

Description

The goal of this PR is to equip the float image viewer with an image sequence caching mechanism in order to support smooth visualization and playback in Meshroom's 2D viewer.

This PR relies on the aliceVision image caching system, including new API calls introduced in this PR: alicevision/AliceVision#1419

Features list

  • image server abstraction for the float image viewer
  • sequence caching system with
    • anticipated prefetching
    • loading progress callbacks
    • exposed cached regions
    • automatic memory limits based on detected RAM

@mugulmd mugulmd self-assigned this Apr 18, 2023
@mugulmd mugulmd force-pushed the mug/sequenceCache branch from 3ccb686 to 7e61363 Compare April 24, 2023 12:27
@mugulmd mugulmd marked this pull request as ready for review April 25, 2023 16:50
@mugulmd mugulmd force-pushed the mug/sequenceCache branch from 047b247 to c24332c Compare May 30, 2023 12:40
@mugulmd mugulmd marked this pull request as draft June 19, 2023 14:52
@mugulmd mugulmd force-pushed the mug/sequenceCache branch from 40522c4 to 608b7ce Compare July 3, 2023 09:52
@mugulmd mugulmd marked this pull request as ready for review July 3, 2023 13:07
@mugulmd mugulmd force-pushed the mug/sequenceCache branch from 608b7ce to 86ac404 Compare July 11, 2023 14:06
Comment on lines 41 to 46
MViewStats.hpp
MTracks.hpp
MSfMDataStats.hpp
SequenceCache.hpp
SingleImageLoader.hpp
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but there are several files in here that trigger AutoMoc warnings during the build, and we might want to look into that at some point (doesn't seem to have any functional impact, though).

@cbentejac cbentejac merged commit b439722 into develop Jul 12, 2023
@cbentejac cbentejac deleted the mug/sequenceCache branch July 12, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants