-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qtAV] Image sequence caching #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ccb686
to
7e61363
Compare
047b247
to
c24332c
Compare
40522c4
to
608b7ce
Compare
608b7ce
to
86ac404
Compare
cbentejac
approved these changes
Jul 12, 2023
Comment on lines
41
to
46
MViewStats.hpp | ||
MTracks.hpp | ||
MSfMDataStats.hpp | ||
SequenceCache.hpp | ||
SingleImageLoader.hpp | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but there are several files in here that trigger AutoMoc warnings during the build, and we might want to look into that at some point (doesn't seem to have any functional impact, though).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to equip the float image viewer with an image sequence caching mechanism in order to support smooth visualization and playback in Meshroom's 2D viewer.
This PR relies on the aliceVision image caching system, including new API calls introduced in this PR: alicevision/AliceVision#1419
Features list