Bugfix for MESHROOM_SUBMITTERS_PATH env variable #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting MESHROOM_SUBMITTERS_PATH caused meshroom to try to load the bundled simpleFarmSubmitter plugin twice, ignoring the path in the variable. I believe the problem lies with the way loadPlugins() works in meshroom.core, because it's trying to import the package name "submitters" more than once. The second time, import_module() just returns a reference to the This is a revised PR based on feedback from the first one I submitted last year, which went stale and then got erased as I was stumbling my way through git.
|
Sorry for not having merged that earlier. |
fabiencastan
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting MESHROOM_SUBMITTERS_PATH caused meshroom to try to load the bundled
simpleFarmSubmitter plugin twice, ignoring the path in the variable.
I believe the problem lies with the way loadPlugins() works in meshroom.core,
because it's trying to import the package name "submitters" more than once. The
second time, import_module() just returns a reference to the
This is a revised PR based on feedback from the first one I submitted last year,
which went stale and then got erased as I was stumbling my way through git.
Description
Features list
Implementation remarks