Fixing meshroom_photogrammetry --input cameras.sfm behaviour #537
Conversation
When meshroom_photogrammetry is called with the --input parameter pointing to a SFM file, then the camera intrinsics and poses are loaded from that file. In this case we should not call CameraInit.buildIntrinsics()
bin/meshroom_photogrammetry
Outdated
| @@ -101,7 +101,8 @@ else: | |||
| graph = multiview.photogrammetry(inputViewpoints=views, inputIntrinsics=intrinsics, output=args.output) | |||
| cameraInit = getOnlyNodeOfType(graph, 'CameraInit') | |||
|
|
|||
| views, intrinsics = cameraInit.nodeDesc.buildIntrinsics(cameraInit, images) | |||
| if not (views and intrinsics): | |||
There was a problem hiding this comment.
Or rather:
if images:
We still want to go through buildIntrinsics when we have "unresolved" input images (from args.inputImages), even when retrieving views and intrinsics from an pre-calibrated sfm file.
Is this okay for your use-case ?
There was a problem hiding this comment.
well, now that #567 has been merged my suggestion is
| if not (views and intrinsics): | |
| if images: | |
| views, intrinsics = cameraInit.nodeDesc.buildIntrinsics(cameraInit, images) | |
| cameraInit.viewpoints.value = views | |
| cameraInit.intrinsics.value = intrinsics |
because:
- whether a default or custom pipeline (
--pipeline) is passed at this pointcameraInitalready has theviewsandintrinsics - if
imageis passed at this point we can read the rest of unresolved images (buildIntrinsics) and updatecameraInit(cameraInit.*.value = ...) - otherwise nothing else need to be done
There was a problem hiding this comment.
It looks like #567 should address the issue I had.
The issue being that the poses and intrinsics loaded from the SFM file would be discarded during initialization.
I do not know (and am unfortunately unable to test) whether the additional changes discussed above are still necessary.
There was a problem hiding this comment.
But the proposed change looks reasonable to me.
When meshroom_photogrammetry is called with the --input parameter pointing to a SFM file, then the camera intrinsics and poses are loaded from that file. In this case we should not call CameraInit.buildIntrinsics()