[bin] meshroom_batch
: Fix input parsing for Windows
#2188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that occurred when executing
meshroom_batch
on Windows. To determine the relationships between the provided input paths and the initialisation nodes, the strings given for the-i
argument is parsed based on ":", which is the expected separator between the node instance and the input path(s).On Linux, this works flawlessly since no path can contain a ":". On Windows however, ":" is a basic character in paths, which led to issues: since the input path was unexpectedly split, it was not correctly recognised, and the
CameraInit
node was never set with that input path. As a consequence, the process was stopping with aNothing to compute for node CameraInit_1.
error.To prevent this, we now check that the first element after the split of the provided argument corresponds to a valid node name: this allows to distinguish an input such as
CameraInit_1:/path/to/images
fromC:/path/to/images
.