Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bin] meshroom_batch: Fix input parsing for Windows #2188

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

cbentejac
Copy link
Contributor

Description

This PR fixes an issue that occurred when executing meshroom_batch on Windows. To determine the relationships between the provided input paths and the initialisation nodes, the strings given for the -i argument is parsed based on ":", which is the expected separator between the node instance and the input path(s).

On Linux, this works flawlessly since no path can contain a ":". On Windows however, ":" is a basic character in paths, which led to issues: since the input path was unexpectedly split, it was not correctly recognised, and the CameraInit node was never set with that input path. As a consequence, the process was stopping with a Nothing to compute for node CameraInit_1. error.

To prevent this, we now check that the first element after the split of the provided argument corresponds to a valid node name: this allows to distinguish an input such as CameraInit_1:/path/to/images from C:/path/to/images.

@cbentejac cbentejac added this to the Meshroom 2023.3.0 milestone Sep 13, 2023
@cbentejac cbentejac self-assigned this Sep 13, 2023
@mugulmd mugulmd merged commit 00133f1 into develop Sep 13, 2023
@mugulmd mugulmd deleted the fix/batchParsingWindows branch September 13, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants