[Texturing] Add option to choose the internal colorspace used for color fusion #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move image processing functions from mvsData::imageIO to the new class mvsData::imageAlgo -> imageIO handles images reading/writing only
- Function to process an image with OpenImageIO parallelization with a custom function - Functions to convert ian image n LAB colorspace
[mesh] [pipeline] add param to choose colorspace for texture computation (unrelated with the output colorspace) [mvsData] imageIO: method to transform a colorspace string to an enum
fabiencastan
reviewed
Jul 4, 2019
| if(colorspace == "sRGB") return EImageColorSpace::SRGB; | ||
| if(colorspace == "LAB") return EImageColorSpace::LAB; | ||
| if(colorspace == "XYZ") return EImageColorSpace::XYZ; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to choose the internal colorspace used in texturing for color fusion: sRGB (default), LAB or XYZ. This has no impact on the colorspace used in the output texture files.
Features list
Implementation remarks
Reorganization of image processing classes. Thus, the imageIO class handle only the reading and writing part, and the new class imageAlgo handle the image processing part. Both are based on OpenImageIO for efficiency.