Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support hooks #980

Merged
merged 5 commits into from
Mar 27, 2019
Merged

feat: support hooks #980

merged 5 commits into from
Mar 27, 2019

Conversation

chenjun1011
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@chenjun1011 chenjun1011 requested a review from yuanyan March 15, 2019 13:15
wssgcg1213
wssgcg1213 approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

yuanyan
yuanyan reviewed Mar 18, 2019
View reviewed changes
packages/rax-server-renderer/src/hookInstance.js Outdated
@@ -0,0 +1,16 @@
class HookInstance {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HookInstance 这个概念可以优化下，其实只有 instance的概念，没有 hook instance 的概念

yuanyan
yuanyan suggested changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@yuanyan yuanyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以简化概念，避免新增文件

@chenjun1011 chenjun1011 changed the title feat: support hooks [WIP] feat: support hooks Mar 18, 2019
@chenjun1011 chenjun1011 changed the title [WIP] feat: support hooks feat: support hooks Mar 27, 2019
@yuanyan yuanyan merged commit fe26846 into master Mar 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/rax-server-renderer branch March 27, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@yuanyan yuanyan yuanyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenjun1011 @yuanyan @wssgcg1213