fix: fragment cache native node #1867
Merged
+56
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjun1011
approved these changes
May 14, 2020
SoloJiang
approved these changes
May 14, 2020
yuanyan
reviewed
May 14, 2020
wssgcg1213
reviewed
May 15, 2020
packages/rax/src/vdom/fragment.js
Outdated
| return []; | ||
| __getNativeNode() { | ||
| const renderedChildren = this.__renderedChildren || {}; | ||
| return Array.prototype.concat.apply([], Object.keys(renderedChildren).map(key => renderedChildren[key].__getNativeNode())); |
There was a problem hiding this comment.
Array.prototype 用 [] 替代会小一点
yuanyan
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fragment的native node 应该类似 composite 一样，应该是个只读的操作
之前的代码都是自上往下考虑 fragment的native node节点
但是fragment本身并不清楚子节点自身更新带来的native node的变化，从而造成内存泄露和bug