Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: should run build command in CI #1410

Closed
wants to merge 1 commit into from
Closed

ci: should run build command in CI #1410

wants to merge 1 commit into from

Conversation

andycall
Copy link
Collaborator

@andycall andycall commented Oct 2, 2019

Should include npm run build in CI.

Now there are build errors in master branch, there issue should be fixed before Pull Request merged:
image

Signed-off-by: andycall <dongtiangche@outlook.com>
@wssgcg1213
Copy link
Collaborator

应该只有本地才会有这个问题, ci 里是全新的环境, 都是重新 link 的, 这个错误的出现原因是:

driver-worker 依赖的 style-unit 是 ^1.0.0, 原来本地的 style-unit 确实是满足这个的, 所以 lerna setup 的时候把 symbol-link 指向了本地路径.

后来 style-unit 升级了 2.0.0 版本, 发生了 break change 的 API, 但是本地的 symbol-link 依然存在, 构建的时候就出现了版本不匹配的现状,但是 ci 里是不存在这个问题的 (会从npm上拉取1.0.0的最新版本)

#1411 升级了 driver-worker 对 style-unit 2.0 的支持

@wssgcg1213 wssgcg1213 closed this Oct 3, 2019
@wssgcg1213
Copy link
Collaborator

另外 npm run setup 里面有运行 buid, 这里不需要重复执行

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants