Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: componentDidMount exec not correct #1399

Merged
merged 2 commits into from
Sep 29, 2019
Merged

fix: componentDidMount exec not correct #1399

merged 2 commits into from
Sep 29, 2019

Conversation

yuanyan
Copy link
Collaborator

@yuanyan yuanyan commented Sep 26, 2019

Current componentDidMount called after appendChild, but the parent is not appendChild to root.

@yuanyan yuanyan requested a review from wssgcg1213 September 27, 2019 16:49
@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
wssgcg1213
wssgcg1213 approved these changes Sep 29, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@yuanyan yuanyan merged commit d2ea864 into master Sep 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-componentDidMount branch September 29, 2019 08:06
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanyan @wssgcg1213