Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support this.renderItem #1310

Merged
merged 18 commits into from
Sep 2, 2019
Merged

Conversation

SoloJiang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

wssgcg1213 and others added 13 commits August 15, 2019 14:44
* docs: update docs of jsx2mp-cli

* Fix/adapt attr key (#1221)

* fix: adapt attribute key

* fix: adapt attribute key

* feat: support jsx2mp-cli arguments, platform [ali,wechat,baidu,tt]
- support platform file suffix;

* fix: fix set distDirectory failure

* fix: jsx2mp page cycles (#1225)

* fix: Modify the extension concept

* fix: modify extension '.*'

* feat: support alipay/wechat jsx2mp-runtime build

* fix: es-lint issue

* refactor: support different adatpers for runtime

* fix: for eslint
* fix: tnpm folder files

* refactor: improve code readablity
* refactor: set default value for jsx2mp-cli

* chore: bump version of jsx2mp-cli
* fix: npm dep file relative path

* fix: missing semicolon  semi
fix: remove weex module requirement
@SoloJiang SoloJiang requested a review from wssgcg1213 August 29, 2019 12:40
@@ -5,7 +5,19 @@ const createJSX = require('../utils/createJSX');
const createBinding = require('../utils/createBinding');
const genExpression = require('../codegen/genExpression');

function transformList(ast, adapter) {
function enhanceIndexOf(arr, checkFn) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个方法的作用是什么? 命名上不够清晰

Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要补充单测

@SoloJiang SoloJiang merged commit b109c6e into release/jsx2mp-0829 Sep 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-render-item branch September 2, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants