-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support this.renderItem #1310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: update docs of jsx2mp-cli * Fix/adapt attr key (#1221) * fix: adapt attribute key * fix: adapt attribute key * feat: support jsx2mp-cli arguments, platform [ali,wechat,baidu,tt] - support platform file suffix; * fix: fix set distDirectory failure * fix: jsx2mp page cycles (#1225) * fix: Modify the extension concept * fix: modify extension '.*' * feat: support alipay/wechat jsx2mp-runtime build * fix: es-lint issue * refactor: support different adatpers for runtime * fix: for eslint
* fix: tnpm folder files * refactor: improve code readablity
* refactor: set default value for jsx2mp-cli * chore: bump version of jsx2mp-cli
* fix: npm dep file relative path * fix: missing semicolon semi
fix: remove weex module requirement
…into release/jsx2mp-0822
wssgcg1213
requested changes
Aug 30, 2019
@@ -5,7 +5,19 @@ const createJSX = require('../utils/createJSX'); | |||
const createBinding = require('../utils/createBinding'); | |||
const genExpression = require('../codegen/genExpression'); | |||
|
|||
function transformList(ast, adapter) { | |||
function enhanceIndexOf(arr, checkFn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个方法的作用是什么? 命名上不够清晰
wssgcg1213
reviewed
Aug 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要补充单测
wssgcg1213
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master
.npm test
).npm run lint
) - we've done our best to make sure these rules match our internal linting guidelines.