Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Migration project deletion #1143

Merged
merged 3 commits into from
Jul 30, 2019
Merged

fix: Migration project deletion #1143

merged 3 commits into from
Jul 30, 2019
+1 −3,380

Conversation

balloonzzq
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@weekly-digest weekly-digest bot mentioned this pull request Jul 21, 2019
Closed
@wssgcg1213 wssgcg1213 self-requested a review July 23, 2019 06:03
wssgcg1213
wssgcg1213 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@wssgcg1213
Copy link
Collaborator

compile-universal.js 的逻辑也需要去掉, ci 挂了

@weekly-digest weekly-digest bot mentioned this pull request Jul 28, 2019
Closed
@yuanyan yuanyan merged commit 47e40bf into alibaba:master Jul 30, 2019
@weekly-digest weekly-digest bot mentioned this pull request Aug 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balloonzzq @CLAassistant @wssgcg1213 @yuanyan