Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: react compatibility #1116

Merged
merged 2 commits into from
Jun 26, 2019
Merged

fix: react compatibility #1116

merged 2 commits into from
Jun 26, 2019

Conversation

94cstyles
Copy link
Contributor

默认导出default，不然会出现下面情况。

import React, { useState } from 'react'

console.log(useState); // function
console.log(React); // undefined

driver-dom 引用有问题

import DriverDOM from 'driver-dom';
// to
import * as DriverDOM from 'driver-dom';

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@94cstyles 94cstyles force-pushed the fix-react-compatibility branch from 1f04c4b to c8ab605 Compare June 26, 2019 05:15
yuanyan
yuanyan reviewed Jun 26, 2019
View reviewed changes
packages/rax-dom/src/index.js Outdated
import hydrate from 'rax-hydrate';
import unmountComponentAtNode from 'rax-unmount-component-at-node';
import findDOMNode from 'rax-find-dom-node';
import createPortal from 'rax-create-portal';

const raxDomRender = (element, container, callback) => render(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑 raxDomRender -> domRender

wssgcg1213
wssgcg1213 approved these changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanyan yuanyan merged commit f4008dd into alibaba:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanyan yuanyan yuanyan approved these changes

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@94cstyles @CLAassistant @yuanyan @wssgcg1213