Feat: Rax PWA #1097
Merged
Feat: Rax PWA #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: eslint error
…into feat-ssr-dev-server
chenjun1011
reviewed
Jul 2, 2019
packages/rax-cli/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "rax-cli", | |||
| "version": "1.4.0", | |||
| "version": "1.4.1-0", | |||
chenjun1011
reviewed
Jul 2, 2019
chenjun1011
reviewed
Jul 2, 2019
| * | ||
| */ | ||
|
|
||
| const RaxPWAPlugins = require('./config/RaxPWAPlugins'); |
There was a problem hiding this comment.
按照上周的结论，应该是细粒度的引用，就没有这个文件了？
There was a problem hiding this comment.
我认为还是需要的，PWA 作为一系列的解决方案，理应需要一种更简单的接入。
chenjun1011
reviewed
Jul 2, 2019
| const path = require('path'); | ||
| const pathToRegexp = require('path-to-regexp'); | ||
|
|
||
| const getSPAPagesConfig = (appConfig, pathConfig) => { |
There was a problem hiding this comment.
pages 有没有可能是外部传入的，这样就和工程结构解耦了
chenjun1011
reviewed
Jul 2, 2019
| import { createElement, useState } from 'rax'; | ||
| import Error from './Error'; | ||
| import isPathMatched from './isPathMatched'; | ||
| import { createHashHistory, createBrowserHistory } from 'history'; |
There was a problem hiding this comment.
单页应用 router 必须依赖 history，不是可选的
chenjun1011
reviewed
Jul 2, 2019
# Conflicts: # packages/rax-scripts/src/config/webapp/client/webpack.config.base.js # packages/rax-ssr-dev-server/index.js
chenjun1011
approved these changes
Jul 3, 2019
wssgcg1213
approved these changes
Jul 3, 2019
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| .DS_Store | |||
| .idea/ | |||
| .temp/ | |||
| import hydrate from 'rax-hydrate'; | ||
| import {render} from 'rax'; | ||
| import * as DriverDOM from 'driver-dom'; | ||
| ${withAppShell === 'true' ? "import AppShell from '../../shell/';" : ''} | ||
| window.onload = function(){ |
| ${functionName}.getInitialProps().then(function(props) { | ||
| hydrate(createElement(${functionName}, props || {}), document.getElementById('root')); | ||
| ${functionName}.getInitialProps().then(function(data) { | ||
| ${renderCodeStr} |
| rax: 'rax', | ||
| }, | ||
| resolve: { | ||
| extensions: ['.js', '.jsx', 'mjs'], |
| }, | ||
| module: { | ||
| rules: [{ | ||
| test: /\.jsx?$/, |
| }); | ||
|
|
||
| try { | ||
| fs.mkdirSync(pathConfig.appDirectory + '/.temp'); |
| compilation.assets['index.html'] = { | ||
| source: () => htmlCode, | ||
| size: () => htmlCode.length | ||
| }; |
There was a problem hiding this comment.
import { RawSource } from 'webpack-sources';
compilation.assets['index.html'] = new RawSource(value);http://unpkg.alibaba-inc.com/webpack-sources/lib/RawSource.js
|
|
||
| const interopRequire = (obj) => { | ||
| return obj && obj.__esModule ? obj.default : obj; | ||
| }; |
chenjun1011
reviewed
Jul 8, 2019
| const isProductionLikeMode = isProductionMode(compiler); | ||
|
|
||
| try { | ||
| fs.mkdirSync(pathConfig.appDirectory + '/.temp'); |
There was a problem hiding this comment.
这里应该需要加下判断 如果已经存在就不需要重复创建
|
准备发布 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过项目 app.json 的配置新增或修改项目代码，更新构建配置增强 Web 体验。
Add or modify the project code through the configuration of project app.json, update the build configuration to enhance the Web experience.