feat: Add component generator #1081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add demo markdown loader
|
|
wssgcg1213
requested changes
Jun 26, 2019
| @@ -9,3 +9,4 @@ node_modules/ | |||
| build/ | |||
| dist/ | |||
| lib/ | |||
| _miniapp/ | |||
| }, | ||
| { | ||
| name: 'Rax UI Component (For Build Rax UI Component)', | ||
| value: 'rax-ui-component' |
There was a problem hiding this comment.
ui component 是一个新概念吗? 跟Component 是不是可以合并?
packages/rax-cli/src/generator/component/demo/miniapp/index.axml
Outdated
Show resolved
Hide resolved
wssgcg1213
requested changes
Jun 26, 2019
| ## CSS API | ||
|
|
||
| | 名称 | 说明 | | ||
| |:---------------|:--------| |
There was a problem hiding this comment.
目前还是放在内网里，这个部分是需要生成文档的，所以默认中文，后续可以加上英文
| build/ | ||
| dist/ | ||
| lib/ | ||
| _miniapp/ |
There was a problem hiding this comment.
_miniapp 这个加入 gitignore 的原因是?
| [packageInfo.name]: path.resolve(process.cwd(), 'src/index') | ||
| } | ||
| }, | ||
| // optimization: { |
wssgcg1213
reviewed
Jun 27, 2019
| // name: false, | ||
| // }, | ||
| // runtimeChunk: true | ||
| // }, |
|
这个什么时候发，着急用 |
myronliu347
approved these changes
Jun 27, 2019
| [packageInfo.name]: path.resolve(process.cwd(), 'src/index') | ||
| } | ||
| }, | ||
| // optimization: { |
|
已经和 @myronliu347 沟通，未来rax-scripts配置能力会做升级，这些feature放在各自业务代码中配置实现。PR关闭。 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
master.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.