Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add component generator #1081

Closed
wants to merge 19 commits into from
Closed

Conversation

battle-ooze
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@wssgcg1213 wssgcg1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

@@ -9,3 +9,4 @@ node_modules/
build/
dist/
lib/
_miniapp/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件夹的作用是?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

生成miniapp 预览的文件夹,不需要提交

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件夹的生成逻辑在哪?

},
{
name: 'Rax UI Component (For Build Rax UI Component)',
value: 'rax-ui-component'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui component 是一个新概念吗? 跟Component 是不是可以合并?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个项目需要使用的模板,暂时不能合并

## CSS API

| 名称 | 说明 |
|:---------------|:--------|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README 用英文吧

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前还是放在内网里,这个部分是需要生成文档的,所以默认中文,后续可以加上英文

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是针对整个 rax 仓库新增代码的要求

Copy link

@myronliu347 myronliu347 Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个部分只是模板,当前模板的README 部分需要是中文的

build/
dist/
lib/
_miniapp/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_miniapp 这个加入 gitignore 的原因是?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

[packageInfo.name]: path.resolve(process.cwd(), 'src/index')
}
},
// optimization: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个部分不确定,先保留吧

// name: false,
// },
// runtimeChunk: true
// },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释的部分如不需要可以删除

@myronliu347
Copy link

这个什么时候发,着急用

[packageInfo.name]: path.resolve(process.cwd(), 'src/index')
}
},
// optimization: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个部分不确定,先保留吧

@wssgcg1213 wssgcg1213 requested a review from yuanyan June 27, 2019 07:41
@Orange-C
Copy link
Collaborator

已经和 @myronliu347 沟通,未来rax-scripts配置能力会做升级,这些feature放在各自业务代码中配置实现。PR关闭。

@Orange-C Orange-C closed this Jul 19, 2019
@wssgcg1213
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants