-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add component generator #1081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
feat: add demo markdown loader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes
@@ -9,3 +9,4 @@ node_modules/ | |||
build/ | |||
dist/ | |||
lib/ | |||
_miniapp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件夹的作用是?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
生成miniapp 预览的文件夹,不需要提交
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件夹的生成逻辑在哪?
}, | ||
{ | ||
name: 'Rax UI Component (For Build Rax UI Component)', | ||
value: 'rax-ui-component' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ui component 是一个新概念吗? 跟Component 是不是可以合并?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
两个项目需要使用的模板,暂时不能合并
packages/rax-cli/src/generator/component/demo/miniapp/index.axml
Outdated
Show resolved
Hide resolved
## CSS API | ||
|
||
| 名称 | 说明 | | ||
|:---------------|:--------| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README 用英文吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前还是放在内网里,这个部分是需要生成文档的,所以默认中文,后续可以加上英文
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是针对整个 rax 仓库新增代码的要求
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个部分只是模板,当前模板的README 部分需要是中文的
build/ | ||
dist/ | ||
lib/ | ||
_miniapp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_miniapp
这个加入 gitignore 的原因是?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
[packageInfo.name]: path.resolve(process.cwd(), 'src/index') | ||
} | ||
}, | ||
// optimization: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个部分不确定,先保留吧
// name: false, | ||
// }, | ||
// runtimeChunk: true | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释的部分如不需要可以删除
这个什么时候发,着急用 |
[packageInfo.name]: path.resolve(process.cwd(), 'src/index') | ||
} | ||
}, | ||
// optimization: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个部分不确定,先保留吧
已经和 @myronliu347 沟通,未来rax-scripts配置能力会做升级,这些feature放在各自业务代码中配置实现。PR关闭。 |
👍 |
Before submitting a pull request, please make sure the following is done...
master
.npm test
).npm run lint
) - we've done our best to make sure these rules match our internal linting guidelines.