Merge pull request #1309 from balloonzzq/fix-performance

Optimize scheduler size and performance
alibaba · Aug 30, 2019 · 45fdcdb · 45fdcdb
2 parents fff9a18 + 83cc827
commit 45fdcdb
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/packages/rax/src/vdom/scheduler.js b/packages/rax/src/vdom/scheduler.js
@@ -19,10 +19,9 @@ export function schedule(callback) {
 
 // Flush before next render
 export function flush() {
-  let callbacks = updateCallbacks;
-  if (callbacks.length !== 0) {
-    updateCallbacks = [];
-    callbacks.forEach(callback => callback());
+  let callback;
+  while (callback = updateCallbacks.shift()) {
+    callback();
   }
 }
 
@@ -34,9 +33,8 @@ export function scheduleEffect(callback) {
 }
 
 export function flushEffect() {
-  let callbacks = effectCallbacks;
-  if (callbacks.length !== 0) {
-    effectCallbacks = [];
-    callbacks.forEach(callback => callback());
+  let callback;
+  while (callback = effectCallbacks.shift()) {
+    callback();
   }
 }