Instance eliminate module naming optimization (#3093)

* Instance eliminate module naming optimization * Solve PMD check failed
alibaba · Jun 17, 2020 · d24f36b · d24f36b
1 parent 67829bb
commit d24f36b
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/naming/src/main/java/com/alibaba/nacos/naming/core/Cluster.java b/naming/src/main/java/com/alibaba/nacos/naming/core/Cluster.java
@@ -347,22 +347,21 @@ private List<Instance> updatedIps(Collection<Instance> newInstance, Collection<I
 
         return new ArrayList<>(instanceMap.values());
     }
-    
-    private List<Instance> subtract(Collection<Instance> a, Collection<Instance> b) {
-        Map<String, Instance> mapa = new HashMap<>(b.size());
-        for (Instance o : b) {
-            mapa.put(o.getIp() + ":" + o.getPort(), o);
+
+    private List<Instance> subtract(Collection<Instance> oldIp, Collection<Instance> ips) {
+        Map<String, Instance> ipsMap = new HashMap<>(ips.size());
+        for (Instance instance : ips) {
+            ipsMap.put(instance.getIp() + ":" + instance.getPort(), instance);
         }
-        
-        List<Instance> result = new ArrayList<>();
-        
-        for (Instance o : a) {
-            if (!mapa.containsKey(o.getIp() + ":" + o.getPort())) {
-                result.add(o);
+
+        List<Instance> instanceResult = new ArrayList<>();
+
+        for (Instance instance : oldIp) {
+            if (!ipsMap.containsKey(instance.getIp() + ":" + instance.getPort())) {
+                instanceResult.add(instance);
             }
         }
-
-        return result;
+        return instanceResult;
     }
 
     @Override