Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix query sibling value is not work #2781

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

janryWang
Copy link
Collaborator

@janryWang janryWang commented Jan 20, 2022

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #2780

Fixed #2777

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #2781 (98f7ebc) into formily_next (25c4897) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2781      +/-   ##
================================================
+ Coverage         95.80%   95.83%   +0.03%     
================================================
  Files               147      147              
  Lines              6344     6344              
  Branches           1763     1763              
================================================
+ Hits               6078     6080       +2     
+ Misses              236      234       -2     
  Partials             30       30              
Impacted Files Coverage Δ
packages/core/src/models/Query.ts 100.00% <100.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c4897...98f7ebc. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2022

Size Change: +9 B (0%)

Total Size: 495 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 19.5 kB +7 B (0%)
packages/core/dist/formily.core.umd.production.js 13.2 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 67.3 kB
packages/antd/dist/formily.antd.umd.production.js 38.6 kB
packages/element/dist/formily.element.umd.development.js 62.8 kB
packages/element/dist/formily.element.umd.production.js 36.5 kB
packages/grid/dist/formily.grid.umd.development.js 9.02 kB
packages/grid/dist/formily.grid.umd.production.js 6.08 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.88 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.35 kB
packages/next/dist/formily.next.umd.development.js 72.8 kB
packages/next/dist/formily.next.umd.production.js 43.3 kB
packages/path/dist/formily.path.umd.development.js 11.1 kB
packages/path/dist/formily.path.umd.production.js 7.66 kB
packages/react/dist/formily.react.umd.development.js 11.4 kB
packages/react/dist/formily.react.umd.production.js 7.09 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.92 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.83 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.3 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.21 kB
packages/shared/dist/formily.shared.umd.development.js 7.39 kB
packages/shared/dist/formily.shared.umd.production.js 4.2 kB
packages/validator/dist/formily.validator.umd.development.js 8.42 kB
packages/validator/dist/formily.validator.umd.production.js 6.25 kB
packages/vue/dist/formily.vue.umd.development.js 16.1 kB
packages/vue/dist/formily.vue.umd.production.js 9.64 kB

compressed-size-action

@janryWang janryWang merged commit c5dfb53 into formily_next Jan 20, 2022
@janryWang janryWang deleted the fix_query_sibling_value_is_not_work branch January 20, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant