Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix array remove can not auto clean initialValue #2638

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #2617

@janryWang janryWang changed the title fix(core): fix array remove can not auto clean initialValu fix(core): fix array remove can not auto clean initialValue Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #2638 (7587fda) into formily_next (8c234a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #2638   +/-   ##
=============================================
  Coverage         95.72%   95.72%           
=============================================
  Files               142      142           
  Lines              6335     6340    +5     
  Branches           1677     1678    +1     
=============================================
+ Hits               6064     6069    +5     
  Misses              271      271           
Impacted Files Coverage Δ
packages/core/src/models/BaseField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c234a8...7587fda. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +79 B (0%)

Total Size: 484 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 19.4 kB +42 B (0%)
packages/core/dist/formily.core.umd.production.js 13.1 kB +37 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 64.5 kB
packages/antd/dist/formily.antd.umd.production.js 36.8 kB
packages/element/dist/formily.element.umd.development.js 62.7 kB
packages/element/dist/formily.element.umd.production.js 36.4 kB
packages/grid/dist/formily.grid.umd.development.js 9.02 kB
packages/grid/dist/formily.grid.umd.production.js 6.08 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.88 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.35 kB
packages/next/dist/formily.next.umd.development.js 69.5 kB
packages/next/dist/formily.next.umd.production.js 41.3 kB
packages/path/dist/formily.path.umd.development.js 11.1 kB
packages/path/dist/formily.path.umd.production.js 7.66 kB
packages/react/dist/formily.react.umd.development.js 11.4 kB
packages/react/dist/formily.react.umd.production.js 7.07 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.86 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.81 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.3 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.21 kB
packages/shared/dist/formily.shared.umd.development.js 7.39 kB
packages/shared/dist/formily.shared.umd.production.js 4.2 kB
packages/validator/dist/formily.validator.umd.development.js 8.42 kB
packages/validator/dist/formily.validator.umd.production.js 6.26 kB
packages/vue/dist/formily.vue.umd.development.js 16.1 kB
packages/vue/dist/formily.vue.umd.production.js 9.66 kB

compressed-size-action

@janryWang janryWang merged commit 2e6db17 into formily_next Dec 17, 2021
@janryWang janryWang deleted the fix_array_mutate branch December 17, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] ArrayField 重复添加删除下标无法赋值默认值
1 participant