Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(antd-component): provide getPopupContainer prop for FormItem when use popover feedback #2619

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

henryzp
Copy link
Contributor

@henryzp henryzp commented Dec 11, 2021

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

image

针对这种排版的错乱,需要Popover组件的getPopupContainer来指定外部容器

因此我给@formily/antd-component的FormItem组件新增了getPopupContainer,用来解决上面的问题

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2021

CLA assistant check
All committers have signed the CLA.

feat: 优化代码
@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #2619 (5a33839) into formily_next (0f9e7a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #2619   +/-   ##
=============================================
  Coverage         95.72%   95.72%           
=============================================
  Files               142      142           
  Lines              6335     6335           
  Branches           1677     1677           
=============================================
  Hits               6064     6064           
  Misses              271      271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9e7a0...5a33839. Read the comment docs.

@janryWang janryWang merged commit 69ff01c into alibaba:formily_next Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants