-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect generated dts in useFieldSchema #2350
Conversation
@janryWang 应该是跨文件了,TS 会重新去查找这个类型的引用路径吧。 monorepo 场景下,TS 的路径解析不总是按照 tsconfig 里面配好的 paths 来解析的。在用 vscode 的 auto import 时应该也有类似的感觉才对。比如有的时候想从 这是 TS 的历史遗留问题了,要让 TS 解决比较难,还是咱们自己规避一下吧。 |
PS. Github Actions 一直不动,求帮看下 |
PR标题不符合规范 |
Codecov Report
@@ Coverage Diff @@
## formily_next #2350 +/- ##
=============================================
Coverage 95.31% 95.31%
=============================================
Files 140 140
Lines 6120 6120
Branches 1543 1543
=============================================
Hits 5833 5833
Misses 282 282
Partials 5 5
Continue to review full report at Codecov.
|
是否可以考虑先发一版?因为这个问题是会让使用了受影响版本的项目无法编译通过的~ 感谢感谢 |
先skipCheckLib吧 |
虽然 ts 可以 skipLibCheck,但是我们项目在 eslint 里面也开启了禁止 any 的一系列规则(@typescript-eslint/no-unsafe-assignment),类型错误会被解析为 any,从而导致 CI 失败。 可以的话还是麻烦尽快发版吧,感谢 |
Before submitting a pull request, please make sure the following is done...
master
orformily_next
.npm test
).npm run lint
) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
What have you changed?
The generated dts file of
@formily/react@2.0.0-rc.17
is incorrect because it has a module reference topackage/json-schema/esm
, which cannot be found outside the main monorepo project of formily.This PR changes the module reference to
@formily/json-schema
.