Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): support more features for page description #2099

Merged
merged 38 commits into from
Sep 13, 2021

Conversation

janryWang
Copy link
Collaborator

@janryWang janryWang commented Sep 3, 2021

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

  1. 内核字段模型支持setValidatorRule API,方便json-schema转换
  2. 内核字段模型支持content属性,方便json-schema转换
  3. 内核字段模型支持submit方法,任何一个字段都能作为一个子表单
  4. 内核字段模型新增提交相关生命周期回调
  5. json-schema 支持普通表达式模式,且会自动依赖收集,重新渲染
  6. json-schema 支持x-value属性,用于支持原地响应式表达式,比如x-value:"{{$form.values.aa * 2}}"
  7. validator支持更多内置校验规则,其实就是把json-schema中定制的规则集成进去了
  8. reactive支持hasCollected函数,用于检测某个执行逻辑是否存在依赖收集
  9. vue 支持default scope

Break Change:

  1. 字段模型errors/warnings/successes 改名selfErrors/selfWarnings/selfSuccesses 原有errors/warnings/successes作为汇总当前节点和所有子节点feedback
  2. 字段模型setErrors/setWarnings/setSuccesses 改名setSelfErrors/setSelfWarnings/setSelfSuccess

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Size Change: +1.26 kB (0%)

Total Size: 2.46 MB

Filename Size Change
packages/antd/dist/formily.antd.umd.development.js 61.4 kB +27 B (0%)
packages/antd/dist/formily.antd.umd.production.js 34.9 kB +25 B (0%)
packages/core/dist/formily.core.umd.development.js 19.6 kB +745 B (+4%)
packages/core/dist/formily.core.umd.production.js 13 kB +620 B (+5%) 🔍
packages/element/dist/formily.element.umd.development.js 55.1 kB +4 B (0%)
packages/element/dist/formily.element.umd.production.js 31.5 kB -1 B (0%)
packages/json-schema/dist/formily.json-schema.umd.development.js 6.73 kB -337 B (-5%)
packages/json-schema/dist/formily.json-schema.umd.production.js 4.19 kB -302 B (-7%)
packages/next/dist/formily.next.umd.development.js 62.9 kB +26 B (0%)
packages/next/dist/formily.next.umd.production.js 36.6 kB +24 B (0%)
packages/path/dist/formily.path.umd.development.js 13.2 kB +74 B (+1%)
packages/path/dist/formily.path.umd.production.js 8.45 kB +47 B (+1%)
packages/react/dist/formily.react.umd.development.js 11.1 kB -248 B (-2%)
packages/react/dist/formily.react.umd.production.js 6.83 kB -233 B (-3%)
packages/reactive/dist/formily.reactive.umd.development.js 8.74 kB +63 B (+1%)
packages/reactive/dist/formily.reactive.umd.production.js 5.01 kB +37 B (+1%)
packages/validator/dist/formily.validator.umd.development.js 8.24 kB +664 B (+9%) 🔍
packages/validator/dist/formily.validator.umd.production.js 6.15 kB +495 B (+9%) 🔍
packages/vue/dist/formily.vue.umd.development.js 14.6 kB -266 B (-2%)
packages/vue/dist/formily.vue.umd.production.js 9.16 kB -203 B (-2%)
ℹ️ View Unchanged
Filename Size
designable/antd/dist/formily.designable.antd.umd.development.js 400 kB
designable/antd/dist/formily.designable.antd.umd.production.js 282 kB
designable/next/dist/formily.designable.next.umd.development.js 412 kB
designable/next/dist/formily.designable.next.umd.production.js 289 kB
designable/setters/dist/formily.designable.antd.umd.development.js 373 kB
designable/setters/dist/formily.designable.antd.umd.production.js 262 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.83 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.8 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #2099 (f3113ca) into formily_next (48f574e) will increase coverage by 2.53%.
The diff coverage is 99.73%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #2099      +/-   ##
================================================
+ Coverage         92.70%   95.24%   +2.53%     
================================================
  Files               136      138       +2     
  Lines              6114     6183      +69     
  Branches           1520     1562      +42     
================================================
+ Hits               5668     5889     +221     
+ Misses              442      289     -153     
- Partials              4        5       +1     
Impacted Files Coverage Δ
packages/core/src/shared/internals.ts 99.64% <99.53%> (+3.85%) ⬆️
packages/core/src/effects/onFieldEffects.ts 97.18% <100.00%> (+0.57%) ⬆️
packages/core/src/effects/onFormEffects.ts 100.00% <100.00%> (ø)
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.10% <100.00%> (-0.12%) ⬇️
packages/core/src/models/Form.ts 100.00% <100.00%> (+0.30%) ⬆️
packages/core/src/models/Heart.ts 100.00% <100.00%> (ø)
packages/core/src/models/ObjectField.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/constants.ts 100.00% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6463371...f3113ca. Read the comment docs.

@janryWang janryWang changed the title refactor(json-schema): support dependency collection in normal expressions refactor(project): support more feature for page description Sep 4, 2021
@janryWang janryWang changed the title refactor(project): support more feature for page description refactor(project): support more features for page description Sep 4, 2021
@janryWang janryWang merged commit 6162ad5 into formily_next Sep 13, 2021
@janryWang janryWang deleted the refactor_schema_expression branch September 13, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants