Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactive): fix dispose omission clean pendding reactions #1994

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #1993

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Size Change: +17 B (0%)

Total Size: 1.58 MB

Filename Size Change
packages/reactive/dist/formily.reactive.umd.development.js 8.68 kB +11 B (0%)
packages/reactive/dist/formily.reactive.umd.production.js 4.98 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
designable/antd/dist/formily.designable.antd.umd.development.js 354 kB
designable/antd/dist/formily.designable.antd.umd.production.js 239 kB
designable/next/dist/formily.designable.next.umd.development.js 332 B
designable/next/dist/formily.designable.next.umd.production.js 252 B
designable/setters/dist/formily.designable.antd.umd.development.js 329 kB
designable/setters/dist/formily.designable.antd.umd.production.js 220 kB
packages/antd/dist/formily.antd.umd.development.js 61.2 kB
packages/antd/dist/formily.antd.umd.production.js 34.8 kB
packages/core/dist/formily.core.umd.development.js 18.7 kB
packages/core/dist/formily.core.umd.production.js 12.4 kB
packages/element/dist/formily.element.umd.development.js 53.6 kB
packages/element/dist/formily.element.umd.production.js 30.5 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 7.13 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 5 kB
packages/next/dist/formily.next.umd.development.js 62.6 kB
packages/next/dist/formily.next.umd.production.js 36.4 kB
packages/path/dist/formily.path.umd.development.js 13.1 kB
packages/path/dist/formily.path.umd.production.js 8.4 kB
packages/react/dist/formily.react.umd.development.js 11.4 kB
packages/react/dist/formily.react.umd.production.js 7.11 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.26 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.79 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.76 kB
packages/shared/dist/formily.shared.umd.development.js 7.38 kB
packages/shared/dist/formily.shared.umd.production.js 4.19 kB
packages/validator/dist/formily.validator.umd.development.js 7.58 kB
packages/validator/dist/formily.validator.umd.production.js 5.66 kB
packages/vue/dist/formily.vue.umd.development.js 14.9 kB
packages/vue/dist/formily.vue.umd.production.js 9.32 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1994 (fadf83b) into formily_next (48f574e) will increase coverage by 0.61%.
The diff coverage is 97.77%.

Impacted file tree graph

@@               Coverage Diff                @@
##           formily_next    #1994      +/-   ##
================================================
+ Coverage         92.70%   93.32%   +0.61%     
================================================
  Files               136      137       +1     
  Lines              6114     6142      +28     
  Branches           1520     1471      -49     
================================================
+ Hits               5668     5732      +64     
+ Misses              442      406      -36     
  Partials              4        4              
Impacted Files Coverage Δ
packages/core/src/models/Form.ts 99.38% <90.00%> (-0.32%) ⬇️
packages/core/src/models/ArrayField.ts 100.00% <100.00%> (ø)
packages/core/src/models/Field.ts 99.21% <100.00%> (+<0.01%) ⬆️
packages/core/src/models/Heart.ts 100.00% <100.00%> (ø)
packages/core/src/models/ObjectField.ts 100.00% <100.00%> (ø)
packages/core/src/models/VoidField.ts 100.00% <100.00%> (ø)
packages/core/src/shared/internals.ts 100.00% <100.00%> (+4.20%) ⬆️
packages/reactive/src/batch.ts 100.00% <0.00%> (ø)
packages/reactive/src/index.ts 100.00% <0.00%> (ø)
packages/reactive/src/autorun.ts 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e06559...fadf83b. Read the comment docs.

@janryWang janryWang merged commit a60134b into formily_next Aug 12, 2021
@janryWang janryWang deleted the fix_dispose_omission_clean_pendding_reactions branch August 12, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] 当schema中存在x-reactions时,ArrayTabs无法删除子项
1 participant