Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): remove property of form values with undefined value #1495

Merged
merged 6 commits into from
May 24, 2021
Merged

feat(core): remove property of form values with undefined value #1495

merged 6 commits into from
May 24, 2021

Conversation

javahuang
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@CLAassistant
Copy link

CLAassistant commented May 24, 2021

CLA assistant check
All committers have signed the CLA.

@janryWang
Copy link
Collaborator

不应该改setValuesIn的,应该是在Field模型的makeReactive里修改

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1495 (c955bef) into formily_next (a0ca5b2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #1495   +/-   ##
=============================================
  Coverage         89.50%   89.50%           
=============================================
  Files               137      137           
  Lines              6004     6004           
  Branches           1529     1529           
=============================================
  Hits               5374     5374           
  Misses              627      627           
  Partials              3        3           
Impacted Files Coverage Δ
packages/core/src/models/Field.ts 99.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ca5b2...c955bef. Read the comment docs.

@janryWang
Copy link
Collaborator

我感觉这里处理会更严格一点,你那种相当于是所有设置value为undefined的行为都会自动删除属性,感觉不够严格,display:none相当于是数据不可见,在这里删除会好一些

@janryWang janryWang merged commit 296eae4 into alibaba:formily_next May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants