Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support FieldBased feature on field for issue #2350 #2357

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

yanxutao89
Copy link
Collaborator

What this PR does / why we need it?

fix support FieldBased feature on field

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.42%. Comparing base (021facc) to head (d35541f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2357      +/-   ##
============================================
- Coverage     77.42%   77.42%   -0.01%     
+ Complexity    22770    22769       -1     
============================================
  Files           634      634              
  Lines         85390    85392       +2     
  Branches      19368    19369       +1     
============================================
- Hits          66114    66111       -3     
- Misses        11253    11256       +3     
- Partials       8023     8025       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenshao wenshao merged commit cf53480 into main Mar 21, 2024
9 checks passed
@yanxutao89 yanxutao89 deleted the fix-2350 branch April 11, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants