Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When target-ip is 127.0.0.1, it is replaced with 0.0.0.0 #131

Closed
hengyunabc opened this issue Sep 21, 2018 · 1 comment
Closed

When target-ip is 127.0.0.1, it is replaced with 0.0.0.0 #131

hengyunabc opened this issue Sep 21, 2018 · 1 comment
Labels
bug Something isn't working
Milestone
3.0.5

Comments

@hengyunabc
Copy link
Collaborator

com.taobao.arthas.core.config.Configure:

    private String normalizeIp(String ip){
        if ("127.0.0.1".equals(ip)) {
            // bind to all network interfaces, allowing remote connections
            return "0.0.0.0";
        }
        return ip;
    }
@hengyunabc hengyunabc added the bug Something isn't working label Sep 21, 2018
@hengyunabc hengyunabc added this to the 3.0.5 milestone Sep 21, 2018
@hengyunabc hengyunabc reopened this Sep 21, 2018
@hengyunabc
Copy link
Collaborator Author

Docs and scripts need to be updated.

lzc-alioo pushed a commit to lzc-alioo/arthas that referenced this issue May 22, 2020
@hengyunabc
remove the code that replaces 127.0.0.1 with 0.0.0.0. fix alibaba#131
dce79cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.5
Development

No branches or pull requests
1 participant
@hengyunabc