Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for yaml dump due to the Argument class #358

Merged
merged 3 commits into from
Sep 5, 2022
Merged

bugfix for yaml dump due to the Argument class #358

merged 3 commits into from
Sep 5, 2022

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Sep 2, 2022

as the title said

@yxdyc yxdyc added the bug Something isn't working label Sep 2, 2022
@yxdyc yxdyc requested review from DavdGao and xieyxclack September 2, 2022 02:48
xieyxclack
xieyxclack approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joneswong joneswong merged commit 438ada4 into alibaba:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xieyxclack xieyxclack xieyxclack approved these changes

@DavdGao DavdGao Awaiting requested review from DavdGao

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yxdyc @xieyxclack @joneswong