Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for the ditto trainer #271

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Jul 29, 2022

fix the wrong model switch judgement of Ditto w.r.t the num_batch & num_epoch.

@yxdyc yxdyc added the bug Something isn't working label Jul 29, 2022
@yxdyc yxdyc requested a review from DavdGao July 29, 2022 07:36
# Conflicts:
#	federatedscope/core/trainers/trainer_Ditto.py
@yxdyc yxdyc requested a review from xieyxclack July 29, 2022 09:54
xieyxclack
xieyxclack previously approved these changes Jul 29, 2022
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack merged commit 3bee14c into alibaba:master Jul 29, 2022
Schichael pushed a commit to Schichael/FederatedScope_thesis that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants