fix: zero warning on flutter analyze

ali77gh · Mar 28, 2023 · 672bb0e · 672bb0e
1 parent 6f71a39
commit 672bb0e
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 12 deletions.
diff --git a/example/integration_test/entry_point_test.dart b/example/integration_test/entry_point_test.dart
@@ -1,8 +1,8 @@
 import 'package:integration_test/integration_test.dart';
 
-import './01.dart' as example01;
-import './02.dart' as example02;
-import './03.dart' as example03;
+import './example_01.dart' as example01;
+import './example_02.dart' as example02;
+import './example_03.dart' as example03;
 
 void main() {
   IntegrationTestWidgetsFlutterBinding.ensureInitialized();

diff --git a/example/integration_test/01.dart → example/integration_test/example_01.dart b/example/integration_test/01.dart → example/integration_test/example_01.dart
diff --git a/example/integration_test/02.dart → example/integration_test/example_02.dart b/example/integration_test/02.dart → example/integration_test/example_02.dart
diff --git a/example/integration_test/03.dart → example/integration_test/example_03.dart b/example/integration_test/03.dart → example/integration_test/example_03.dart
diff --git a/example/lib/03_2_depends_on_async/depends_on_async_sample.dart b/example/lib/03_2_depends_on_async/depends_on_async_sample.dart
@@ -16,7 +16,7 @@ class DependObservableAsyncSampleLayoutState
   late Telescope<int> weight;
   late Telescope<double> bmi;
   late Telescope<String> showingText;
-  var  loadingBMI = Telescope(false);
+  var loadingBMI = Telescope(false);
 
   @override
   void initState() {
@@ -31,7 +31,11 @@ class DependObservableAsyncSampleLayoutState
 
     showingText = Telescope.dependsOn([height, weight, bmi, loadingBMI], () {
       var bmis = bmi.value.toString();
-      bmis = loadingBMI.value ? "..." : bmis.length > 5 ? bmis.substring(0, 5) : bmis;
+      bmis = loadingBMI.value
+          ? "..."
+          : bmis.length > 5
+              ? bmis.substring(0, 5)
+              : bmis;
 
       return "weight is ${weight.value} and height is ${height.value} so bmi will be $bmis";
     });

diff --git a/lib/src/telescope.dart b/lib/src/telescope.dart
@@ -45,11 +45,12 @@ class Telescope<T> {
   /// Async version of [Telescope.dependsOn]
   /// Use this if you need to use await in calculate function
   Telescope.dependsOnAsync(
-      this.holden, List<Telescope> dependencies, Future<T> Function() calculate,
-      {
-        this.iWillCallNotifyAll = false,
-        Telescope<bool>? isCalculating,
-      }) {
+    this.holden,
+    List<Telescope> dependencies,
+    Future<T> Function() calculate, {
+    this.iWillCallNotifyAll = false,
+    Telescope<bool>? isCalculating,
+  }) {
     isCalculating?.value = true;
     calculate().then((value) {
       holden = value;

diff --git a/test/save_and_load_test.dart b/test/save_and_load_test.dart
@@ -14,6 +14,8 @@ class Human {
   String name = "";
   @override
   int get hashCode => name.hashCode;
+  @override
+  bool operator ==(Object other) => hashCode == other.hashCode;
 }
 
 class HumanSerializer extends OnDiskSaveAbility<Human> {

diff --git a/test/type_check_test.dart b/test/type_check_test.dart
@@ -62,6 +62,9 @@ class HashCodeHuman {
   int age = 18;
   @override
   int get hashCode => age.hashCode;
+
+  @override
+  bool operator ==(Object other) => hashCode == other.hashCode;
 }
 
 void implementsHashCodeTest() {
@@ -94,7 +97,7 @@ void checkValidTypeTest() {
     test("not supported Human", () {
       expect(() {
         TypeCheck.checkIsValidType<Human>(Human(), false);
-      }, throwsA(TypeMatcher()));
+      }, throwsA(const TypeMatcher()));
     });
 
     test("not supported Human iWillCallNotifyAll", () {
@@ -123,7 +126,7 @@ void checkValidTypeItemsTest() {
     test("not supported Human", () {
       expect(() {
         TypeCheck.checkIsValidTypeForItems([Human(), Human()], false);
-      }, throwsA(TypeMatcher()));
+      }, throwsA(const TypeMatcher()));
     });
 
     test("not supported Human list iWillCallNotifyAll", () {