-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account min balance field #1596
Conversation
5ce3a09
to
7d2f55e
Compare
7d2f55e
to
175cdb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
+ Coverage 68.54% 68.80% +0.25%
==========================================
Files 37 38 +1
Lines 7452 7517 +65
==========================================
+ Hits 5108 5172 +64
- Misses 1914 1915 +1
Partials 430 430 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks good to me. I cannot officially approve since I opened this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Add the minimum balance field to accounts returned over the REST API.
Fixes #808
Test Plan
Added a minBalance unit test exercising the core minBalance formula (parallels that in go-algorand).