Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Correct deadline comment issue#6201 #6241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pao-beep
Copy link

@pao-beep pao-beep commented Feb 1, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (e60d3dd) to head (d46a314).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6241      +/-   ##
==========================================
+ Coverage   49.25%   51.76%   +2.51%     
==========================================
  Files         644      644              
  Lines       86521    86521              
==========================================
+ Hits        42617    44789    +2172     
+ Misses      41040    38869    -2171     
+ Partials     2864     2863       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf requested review from cce and algorandskiy February 5, 2025 02:33
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this is correct

@gmalouf gmalouf changed the title Correct deadline comment issue#6201 Comments: Correct deadline comment issue#6201 Feb 6, 2025
@gmalouf
Copy link
Contributor

gmalouf commented Feb 6, 2025

@pao-beep can you sign the contributor license agreement?

@pao-beep
Copy link
Author

pao-beep commented Feb 7, 2025

@pao-beep can you sign the contributor license agreement?

where do i sign

@gmalouf
Copy link
Contributor

gmalouf commented Feb 7, 2025 via email

@algorandskiy
Copy link
Contributor

algorandskiy commented Feb 7, 2025

Scroll down the checks list at of this page and click on Details on the License/CLA row as on this screenshot:

image

@pao-beep
Copy link
Author

pao-beep commented Feb 7, 2025

Thank you both signed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants