Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchpoints: add accountsRound check against R-320 horizon values to catchpointFileWriter #6240

Merged
merged 16 commits into from
Feb 12, 2025

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 29, 2025

Summary

Fix issue with onlineaccounts updateRound column for certain accounts in catchpoint files when updateRound < R-320. Renames MakeOnlineAccountsIter to MakeOrderedOnlineAccountsIter (without logic changes) so it is more clear the DB provides an ordering on (account, updround).

Test Plan

Update tests and add new ones.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.78%. Comparing base (121df6f) to head (76676f0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ledger/catchpointfilewriter.go 83.33% 1 Missing and 1 partial ⚠️
...edger/store/trackerdb/sqlitedriver/sqlitedriver.go 0.00% 2 Missing ⚠️
cmd/catchpointdump/file.go 0.00% 1 Missing ⚠️
ledger/catchupaccessor.go 0.00% 1 Missing ⚠️
ledger/store/trackerdb/dualdriver/dualdriver.go 0.00% 1 Missing ⚠️
ledger/store/trackerdb/generickv/reader.go 0.00% 1 Missing ⚠️
ledger/store/trackerdb/sqlitedriver/kvsIter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6240      +/-   ##
==========================================
+ Coverage   51.76%   51.78%   +0.02%     
==========================================
  Files         644      644              
  Lines       86523    86533      +10     
==========================================
+ Hits        44791    44815      +24     
+ Misses      38864    38854      -10     
+ Partials     2868     2864       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce force-pushed the fix-catchpoint-onlineaccts-horizon branch from af3bdfb to ce9b32c Compare February 10, 2025 20:14
@cce cce marked this pull request as ready for review February 10, 2025 22:54
algorandskiy
algorandskiy previously approved these changes Feb 11, 2025
jannotti
jannotti previously approved these changes Feb 11, 2025
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me! I don't feel strongly about the Address vs *Address thing. You can resolve if you prefer the pointer.

ledger/catchpointfilewriter.go Outdated Show resolved Hide resolved
@cce cce dismissed stale reviews from jannotti and algorandskiy via 5c217fd February 11, 2025 16:27
algorandskiy
algorandskiy previously approved these changes Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants