-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catchpoints: add accountsRound check against R-320 horizon values to catchpointFileWriter #6240
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6240 +/- ##
==========================================
+ Coverage 51.76% 51.78% +0.02%
==========================================
Files 644 644
Lines 86523 86533 +10
==========================================
+ Hits 44791 44815 +24
+ Misses 38864 38854 -10
+ Partials 2868 2864 -4 ☔ View full report in Codecov by Sentry. |
…lineaccts-horizon
af3bdfb
to
ce9b32c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems right to me! I don't feel strongly about the Address
vs *Address
thing. You can resolve if you prefer the pointer.
Summary
Fix issue with onlineaccounts updateRound column for certain accounts in catchpoint files when updateRound < R-320. Renames MakeOnlineAccountsIter to MakeOrderedOnlineAccountsIter (without logic changes) so it is more clear the DB provides an ordering on (account, updround).
Test Plan
Update tests and add new ones.