-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: allow metrics filtering by labels in metrics_viz.py #6125
scripts: allow metrics filtering by labels in metrics_viz.py #6125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6125 +/- ##
==========================================
+ Coverage 56.17% 56.19% +0.01%
==========================================
Files 494 494
Lines 69931 69931
==========================================
+ Hits 39286 39297 +11
+ Misses 27966 27957 -9
+ Partials 2679 2677 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, but fine with it overall.
1dc50b9
to
2f4250a
Compare
2f4250a
to
60e4f42
Compare
Summary
Updates to heapwatch tooling for metrics analysis:
metrics_viz.py
Test Plan
This allows to run aggs/viz scripts against high-freq scrapped metrics by heapwatch tooling like this
and get subset of
libp2p_rcmgr_streams
values to look at: