Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: allow metrics filtering by labels in metrics_viz.py #6125

Merged

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Sep 6, 2024

Summary

Updates to heapwatch tooling for metrics analysis:

  1. Allow tags filters in metrics_viz.py
  2. Support repeated tag values
  3. Allow heapwatch to enable mutex and blocking profile

Test Plan

This allows to run aggs/viz scripts against high-freq scrapped metrics by heapwatch tooling like this

python3 ./test/heapwatch/metrics_viz.py -d /data/networks/p2p-200-1/metrics/500x15 libp2p_rcmgr_streams --nick-re 'name_n\d+' -s html -t protocol=/meshsub/1.1.0 -t protocol=/algorand-ws/1.0.0

and get subset of libp2p_rcmgr_streams values to look at:
image

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.19%. Comparing base (66b87dc) to head (60e4f42).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6125      +/-   ##
==========================================
+ Coverage   56.17%   56.19%   +0.01%     
==========================================
  Files         494      494              
  Lines       69931    69931              
==========================================
+ Hits        39286    39297      +11     
+ Misses      27966    27957       -9     
+ Partials     2679     2677       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but fine with it overall.

gmalouf
gmalouf previously approved these changes Sep 9, 2024
@algorandskiy algorandskiy force-pushed the pavel/heapwatch-memtrics-viz branch from 2f4250a to 60e4f42 Compare September 10, 2024 17:24
@algorandskiy algorandskiy merged commit 3b3b5ce into algorand:master Sep 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants