Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add EnableGossipService option #5832

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

ohill
Copy link
Contributor

@ohill ohill commented Nov 14, 2023

Summary

This adds a configuration option EnableGossipService, true by default, for whether to serve the /v1/{genesisID}/gossip HTTP endpoint on the port configured in NetAddress. This could be useful for algod nodes that want to only serve the blocks HTTP endpoint (EnableBlockService) and/or the catchpoint file HTTP endpoint (EnableLedgerService) on the NetAddress port.

Test Plan

Added new test "TestWebsocketNetworkNoGossipService"

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (90b10d2) 55.81% compared to head (31d9c9f) 55.85%.
Report is 1 commits behind head on master.

Files Patch % Lines
network/wsNetwork.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5832      +/-   ##
==========================================
+ Coverage   55.81%   55.85%   +0.03%     
==========================================
  Files         476      476              
  Lines       67138    67142       +4     
==========================================
+ Hits        37476    37503      +27     
+ Misses      27141    27119      -22     
+ Partials     2521     2520       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohill ohill force-pushed the config-gossip-service branch from bd8c31a to 555c4c8 Compare November 15, 2023 16:55
algorandskiy
algorandskiy previously approved these changes Nov 15, 2023
network/wsNetwork_test.go Show resolved Hide resolved
Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@algorandskiy algorandskiy merged commit 89a1930 into algorand:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants