-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add participation key generation endpoint to algod API #5781
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5781 +/- ##
=======================================
Coverage 55.53% 55.53%
=======================================
Files 473 474 +1
Lines 66815 66851 +36
=======================================
+ Hits 37105 37127 +22
- Misses 27192 27199 +7
- Partials 2518 2525 +7
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some comments that I forgot to submit. I think I still have more to look at and understand though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some very small nits, but approving. If you want to change them, I'll reapprove immediately. Up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Implementation for #5578.
New endpoint for the admin API to generate and install participation keys.
The participation keys are generated in the background and installed when generation is complete. With this PR there is no progress reporting. Programs should poll the
GET /v2/participation
endpoint and look for the new key to appear. Once the new key is installed a key registration transaction can be made.Test Plan
New unit tests.