-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEAL: Report columns in TEAL source maps #5776
Merged
gmalouf
merged 7 commits into
algorand:master
from
jasonpaulos:teal-source-map-report-columns
Oct 11, 2023
Merged
TEAL: Report columns in TEAL source maps #5776
gmalouf
merged 7 commits into
algorand:master
from
jasonpaulos:teal-source-map-report-columns
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5776 +/- ##
==========================================
+ Coverage 51.51% 55.45% +3.94%
==========================================
Files 473 473
Lines 66688 66708 +20
==========================================
+ Hits 34354 36993 +2639
+ Misses 29742 27194 -2548
+ Partials 2592 2521 -71
... and 150 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
previously approved these changes
Oct 5, 2023
* Use the OpStream's OffSetToSource directly * Use deltas properly
jannotti
previously approved these changes
Oct 6, 2023
aff88d2
to
93ae432
Compare
jannotti
previously approved these changes
Oct 10, 2023
gmalouf
previously approved these changes
Oct 11, 2023
jannotti
reviewed
Oct 11, 2023
jannotti
approved these changes
Oct 11, 2023
gmalouf
approved these changes
Oct 11, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this, TEAL source maps would only map PCs to line numbers, always assuming the column was 0. Since multiple opcodes can now be placed on a single line, separated by
;
, it makes sense to also report the source column as well.Additionally, I also made the path to the source file relative to the source map file, which is what the specification requires (see Resolving Sources). Prior to this PR, we were just using whatever the user input as the source program path.
Test Plan
Existing unit tests updated and added an additional e2e test to expand coverage of more complicated cases.