-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add MaxBlockHistoryLookback option #5749
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5749 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 476 476
Lines 66857 66859 +2
=======================================
+ Hits 37156 37160 +4
+ Misses 27177 27175 -2
Partials 2524 2524
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
Do we ever complain about non-sensical combinations of config? If someone sets this to, say, 3000 but also has Archival set, they are probably confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code LGTM but please add a unit test and perform a manual test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change!
Manually tested after catchpoint restore & running a node for a little while with "MaxBlockHistoryLookback": 1500 set:
|
Summary
There is no way to request a node to store more blocks if it is not archival. This adds a MaxBlockHistoryLookback similar to MaxAcctLookback config option.
Test Plan
No tests yet