tests: update TestCatchupOverGossip to be less parallel and use sub-tests #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
approved these changes
Sep 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #5731 +/- ##
==========================================
- Coverage 55.54% 50.62% -4.92%
==========================================
Files 476 476
Lines 66853 66853
==========================================
- Hits 37131 33842 -3289
- Misses 27193 30423 +3230
- Partials 2529 2588 +59 see 143 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
algorandskiy
reviewed
Sep 8, 2023
algorandskiy
approved these changes
Sep 8, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test creates 4 networks while it is running, so removing the call to t.Parallel should help it finish quicker, and splitting up the subtests with t.Run makes it easier to see which test network is running.
Test Plan
Existing test should pass