Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate: Enable on follower node & allow specifying starting round #5685

Merged
merged 10 commits into from
Aug 29, 2023

Conversation

jasonpaulos
Copy link
Contributor

@jasonpaulos jasonpaulos commented Aug 18, 2023

Summary

Fixes #5651

Additionally, adds simulate option to choose the round the simulation should be based on (instead of always using latest).

Test Plan

  • Unit test added to check that the Simulate methods works on AlgorandFollowerNode
  • Unit & e2e tests added to ensure simulate can use a different starting round

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #5685 (126a544) into master (10f2f55) will increase coverage by 0.39%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master    #5685      +/-   ##
==========================================
+ Coverage   55.06%   55.45%   +0.39%     
==========================================
  Files         473      473              
  Lines       66281    66316      +35     
==========================================
+ Hits        36495    36777     +282     
+ Misses      27285    27038     -247     
  Partials     2501     2501              
Files Changed Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.80% <ø> (ø)
daemon/algod/api/server/v2/utils.go 7.59% <0.00%> (-0.03%) ⬇️
ledger/acctupdates.go 70.91% <0.00%> (-0.63%) ⬇️
ledger/ledger.go 68.88% <0.00%> (-0.69%) ⬇️
cmd/goal/clerk.go 9.42% <33.33%> (+0.08%) ⬆️
ledger/simulation/simulator.go 82.90% <89.47%> (+3.10%) ⬆️
node/follower_node.go 45.16% <100.00%> (ø)

... and 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonpaulos jasonpaulos marked this pull request as ready for review August 24, 2023 20:59
@jasonpaulos jasonpaulos changed the title Simulate: Enable on follower node Simulate: Enable on follower node & allow specifying starting round Aug 24, 2023
jannotti
jannotti previously approved these changes Aug 25, 2023
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems right to me, just asking questions for understandings.

jannotti
jannotti previously approved these changes Aug 25, 2023
ahangsu
ahangsu previously approved these changes Aug 28, 2023
@jasonpaulos jasonpaulos dismissed stale reviews from ahangsu and jannotti via 126a544 August 29, 2023 18:31
@jasonpaulos jasonpaulos requested a review from jannotti August 29, 2023 19:34
@bbroder-algo bbroder-algo merged commit 2670e94 into algorand:master Aug 29, 2023
@jasonpaulos jasonpaulos deleted the simulate-follower-node branch August 29, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Simulate on a Follow mode-configured algod
5 participants