-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate: Enable on follower node & allow specifying starting round #5685
Simulate: Enable on follower node & allow specifying starting round #5685
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5685 +/- ##
==========================================
+ Coverage 55.06% 55.45% +0.39%
==========================================
Files 473 473
Lines 66281 66316 +35
==========================================
+ Hits 36495 36777 +282
+ Misses 27285 27038 -247
Partials 2501 2501
... and 36 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems right to me, just asking questions for understandings.
Summary
Fixes #5651
Additionally, adds simulate option to choose the round the simulation should be based on (instead of always using latest).
Test Plan
Simulate
methods works onAlgorandFollowerNode