ledger: fix error condition leaked from KV-related refactoring #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetechnical
approved these changes
Aug 17, 2023
AlgoAxel
approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #5678 +/- ##
==========================================
- Coverage 55.21% 54.90% -0.32%
==========================================
Files 465 465
Lines 64971 64971
==========================================
- Hits 35873 35671 -202
- Misses 26712 26894 +182
- Partials 2386 2406 +20
... and 37 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pulling a error checking bugfix from #5677 introduced #5451 by me.
Test Plan
Existing tests