chore: Remove faulty assertion #5675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5675 +/- ##
==========================================
+ Coverage 55.15% 55.17% +0.02%
==========================================
Files 465 465
Lines 65003 65003
==========================================
+ Hits 35850 35864 +14
+ Misses 26760 26756 -4
+ Partials 2393 2383 -10 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Aug 16, 2023
algonautshant
approved these changes
Aug 17, 2023
winder
approved these changes
Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test is flaky (see failed nightly run in https://app.circleci.com/pipelines/github/algorand/go-algorand/16122/workflows/feaae371-cb4f-49a5-becc-f46f2ef422d5/jobs/250292).
I've removed the assertion that the generated lists would have no duplicates--clearly the rapid test framework can and will generate some duplicates and it really doesn't matter to the logic of the test if it does.
Test Plan
Tests pass--haven't seen other parts of the test be flaky as far as I know.