tools: test on CI regardless of modded file #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5621 +/- ##
==========================================
+ Coverage 54.95% 55.01% +0.06%
==========================================
Files 463 463
Lines 64525 64525
==========================================
+ Hits 35457 35499 +42
+ Misses 26684 26652 -32
+ Partials 2384 2374 -10 see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
commented
Jul 31, 2023
added 2 commits
July 31, 2023 17:45
winder
reviewed
Aug 1, 2023
winder
previously approved these changes
Aug 1, 2023
winder
approved these changes
Aug 1, 2023
Eric-Warehime
approved these changes
Aug 1, 2023
cce
reviewed
Aug 2, 2023
cce
approved these changes
Aug 2, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow file for the GA tools job was too narrow. It ought to run on every PR against
master.Now that it's running it can detect problems on changes to ConsensusParams as here.
After the SDK's ConsensusParams were fixed the test is passing as well.