-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netdeploy: allow simple local net topologies #5612
netdeploy: allow simple local net topologies #5612
Conversation
b73db76
to
58cdb9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5612 +/- ##
==========================================
- Coverage 54.99% 54.94% -0.05%
==========================================
Files 460 460
Lines 64439 64450 +11
==========================================
- Hits 35436 35413 -23
- Misses 26637 26665 +28
- Partials 2366 2372 +6
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to figure out why PeerList is treated as a semicolon delimited string instead of as a []string. But this does indeed work, and I am assuming there's a serialization need, so 👍
Summary
Changes to netdeploy to control local net topologies. Motivation is allow some networking tests on a local machine without spinning up a cluster.
Implementation Notes:
PeerList
property into local net templatesTemplateFile
with actualTemplate
in deployed templatenetwork.json
since the former was not used.PeerList
in network template start (goal network -r xxx start
)Test Plan
Added some unit test. Tested manually with
FiveNodesTwoRelays.json
templates that forces NPN to connect a single relay, and one of part nodes to connect to another single relay.NonPartNode connects only R1, PartNode1 connects to both, and PartNode2 connects only to R2 as the templates specifies: