Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: fixes to store interface after kv merge #5607

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

icorderi
Copy link
Contributor

Summary

Quick fix of some missing interface changes that were in master but not on PR #5488

Test Plan

Existing tests.

@icorderi icorderi force-pushed the fix/master-compile-error branch from 3504149 to cc4e7a4 Compare July 25, 2023 15:47
Copy link
Contributor

@AlgoAxel AlgoAxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that interfaces changed and were not noticed when the previous change (#5534 and/or #5488 ?) was made.

  1. The title of this PR does not match the branch name or the description, isn't this "fix: interface changes in store interface"?

  2. You have a code generation error in the store package, regarding msgpk. @iansuvak may have some insight.

@icorderi icorderi force-pushed the fix/master-compile-error branch from 070bcf7 to cc4e7a4 Compare July 25, 2023 16:09
@algorandskiy algorandskiy changed the title feat: impl changes in store interface ledger: fixes to store interface after kv merge Jul 25, 2023
@icorderi icorderi requested a review from AlgoAxel July 25, 2023 16:28
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #5607 (9412c4d) into master (1d1fe0f) will decrease coverage by 0.83%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5607      +/-   ##
==========================================
- Coverage   55.79%   54.97%   -0.83%     
==========================================
  Files         446      460      +14     
  Lines       63490    64441     +951     
==========================================
+ Hits        35425    35427       +2     
- Misses      25694    26643     +949     
  Partials     2371     2371              
Files Changed Coverage Δ
...r/store/trackerdb/generickv/accounts_ext_reader.go 0.00% <0.00%> (ø)
...r/store/trackerdb/generickv/accounts_ext_writer.go 0.00% <0.00%> (ø)
...edger/store/trackerdb/generickv/accounts_reader.go 0.00% <0.00%> (ø)
...edger/store/trackerdb/generickv/accounts_writer.go 0.00% <0.00%> (ø)
ledger/store/trackerdb/generickv/catchpoint.go 0.00% <0.00%> (ø)
ledger/store/trackerdb/generickv/init_accounts.go 0.00% <0.00%> (ø)
ledger/store/trackerdb/generickv/migrations.go 0.00% <0.00%> (ø)
...store/trackerdb/generickv/onlineaccounts_reader.go 0.00% <0.00%> (ø)
...store/trackerdb/generickv/onlineaccounts_writer.go 0.00% <0.00%> (ø)
ledger/store/trackerdb/generickv/reader.go 0.00% <0.00%> (ø)
... and 4 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 670010a into algorand:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants