-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger: fixes to store interface after kv merge #5607
ledger: fixes to store interface after kv merge #5607
Conversation
3504149
to
cc4e7a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that interfaces changed and were not noticed when the previous change (#5534 and/or #5488 ?) was made.
-
The title of this PR does not match the branch name or the description, isn't this "fix: interface changes in store interface"?
-
You have a code generation error in the store package, regarding msgpk. @iansuvak may have some insight.
070bcf7
to
cc4e7a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #5607 +/- ##
==========================================
- Coverage 55.79% 54.97% -0.83%
==========================================
Files 446 460 +14
Lines 63490 64441 +951
==========================================
+ Hits 35425 35427 +2
- Misses 25694 26643 +949
Partials 2371 2371
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
Quick fix of some missing interface changes that were in master but not on PR #5488
Test Plan
Existing tests.