Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: downgrade ubuntu to 20.04 and ensure ARM64 binaries are built static #5555

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Jul 11, 2023

Summary

With dynamic libraries, building on older OSes would be supported, but not vice versa. As we were updating OSes, ARM64 builds started failing due to dynamic builds on newer platforms. I.e., if you built a binary on ubuntu. 22.04, it would not run on 20.04, due to lack of static linking in ARM64.

This fix does three things:

  • Expand static builds outside of CentOS
  • Revert build environments to 20.04
  • Cherry-pick in the orb/container upgrade for CI

Ubuntu 22.04 showed some downstream incompatibilities when building RPMs, so is rolled back for now.

An additional change is to bump the required labels github action version, but this is separate from the above fixes.

Test Plan

Built command line, to verify it would build a static binary.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #5555 (c2d2e46) into rel/beta (e21b905) will decrease coverage by 0.70%.
The diff coverage is n/a.

❗ Current head c2d2e46 differs from pull request most recent head 42ebb5d. Consider uploading reports for the commit 42ebb5d to get more accurate results

@@             Coverage Diff              @@
##           rel/beta    #5555      +/-   ##
============================================
- Coverage     56.51%   55.81%   -0.70%     
============================================
  Files           450      446       -4     
  Lines         63324    63273      -51     
============================================
- Hits          35785    35314     -471     
- Misses        25151    25583     +432     
+ Partials       2388     2376      -12     

see 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@onetechnical onetechnical changed the title Bugfix: ensure ARM64 binaries are built static Bugfix: downgrade ubuntu to 20.04 and ensure ARM64 binaries are built static Jul 13, 2023
@onetechnical onetechnical changed the base branch from rel/beta to master July 13, 2023 18:23
@onetechnical onetechnical changed the base branch from master to rel/beta July 13, 2023 18:24
@onetechnical onetechnical marked this pull request as ready for review July 13, 2023 18:24
@onetechnical onetechnical changed the title Bugfix: downgrade ubuntu to 20.04 and ensure ARM64 binaries are built static CICD: downgrade ubuntu to 20.04 and ensure ARM64 binaries are built static Jul 13, 2023
@onetechnical onetechnical requested review from a team, excalq and algobarb July 13, 2023 18:27
@algojohnlee algojohnlee merged commit 18a33c9 into algorand:rel/beta Jul 14, 2023
@onetechnical onetechnical deleted the static-fix branch April 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants