-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICD: downgrade ubuntu to 20.04 and ensure ARM64 binaries are built static #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rel/beta #5555 +/- ##
============================================
- Coverage 56.51% 55.81% -0.70%
============================================
Files 450 446 -4
Lines 63324 63273 -51
============================================
- Hits 35785 35314 -471
- Misses 25151 25583 +432
+ Partials 2388 2376 -12 see 35 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algobarb
approved these changes
Jul 13, 2023
tzaffi
approved these changes
Jul 13, 2023
winder
approved these changes
Jul 13, 2023
algorandskiy
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With dynamic libraries, building on older OSes would be supported, but not vice versa. As we were updating OSes, ARM64 builds started failing due to dynamic builds on newer platforms. I.e., if you built a binary on ubuntu. 22.04, it would not run on 20.04, due to lack of static linking in ARM64.
This fix does three things:
Ubuntu 22.04 showed some downstream incompatibilities when building RPMs, so is rolled back for now.
An additional change is to bump the required labels github action version, but this is separate from the above fixes.
Test Plan
Built command line, to verify it would build a static binary.