-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Additional private network options and container tweaks. #5525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
- Coverage 55.83% 55.80% -0.03%
==========================================
Files 446 446
Lines 63258 63258
==========================================
- Hits 35321 35303 -18
- Misses 25561 25577 +16
- Partials 2376 2378 +2 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I've familiarized myself a bit with gosu, which directly Docker's own user handling code for privilege de-escalation.
I'd be interested to know more about testing this private network configuration. It could even be useful for dogfooding new telemetry configurations.
Summary
Add support for configuring a private network with networking enabled, and for adding peers to a non-standard relay.
This is done by adding the following options:
GENESIS_ADDRESS
- allows a peer node to resolvegenesis.json
through the REST API.GOSSIP_PORT
- sets theNetAddress
, ensuresDisableNetworking
is false, and setsIncomingConnectionsLimit
to 1000.Additional tweaks:
ALGORAND_DATA
value sanity check. It should not be overridden.runuser
togosu
to more closely follow conventions in other high quality docker images.Test Plan
Manual testing: