config: update MaxCatchpointDownloadDuration to 12h #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
approved these changes
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #5503 +/- ##
==========================================
- Coverage 55.82% 55.80% -0.02%
==========================================
Files 446 446
Lines 63224 63224
==========================================
- Hits 35292 35283 -9
- Misses 25565 25569 +4
- Partials 2367 2372 +5
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gmalouf
approved these changes
Jun 27, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today the catchpoint restore system waits for a maximum of 2 hours to download a snapshot before giving up. Since this parameter was originally set, the size of a snapshot has increased by several times. This increases the default
MaxCatchpointDownloadDurationconfiguration value to 12h.Test Plan
Configuration update only; existing tests should pass.